Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add slots option to component constructor options object #2684

Closed
wants to merge 5 commits into from

Conversation

creaven
Copy link

@creaven creaven commented May 5, 2019

Add option to set slots when create component instance

fixes #2588

@ematipico
Copy link
Contributor

Is there any update on this PR?

@codecov-io
Copy link

codecov-io commented Sep 9, 2019

Codecov Report

Merging #2684 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2684   +/-   ##
=======================================
  Coverage   50.25%   50.25%           
=======================================
  Files           1        1           
  Lines         197      197           
=======================================
  Hits           99       99           
  Misses         98       98

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d8ca9f...26fe10f. Read the comment docs.

@Tbutnyakov
Copy link

Any news?

@fabian-michael
Copy link

Hi, any news?

@benkissi
Copy link

Any progress on this?

@ematipico
Copy link
Contributor

@Conduitry @Rich-Harris is there some interest in this pr? It's been hanging for a bit now

@ghost
Copy link

ghost commented Jan 21, 2020

@ematipico,

Unfortunately, this PR and as well as many others are awaiting a full re-base and/or re-implementation due to major changes to Svelte internals.

It's up to the author to keep their PRs current and in clean state.
See my referenced issue for a list of PRs that can't be cleanly merged (may be a bit out of date).

@Conduitry
Copy link
Member

Closing in favor of the rebased #4296.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to set slots when create component instance
7 participants